]> granicus.if.org Git - llvm/commit
[ThinLTO] Only promote exported locals as marked in index
authorTeresa Johnson <tejohnson@google.com>
Mon, 14 Nov 2016 19:21:41 +0000 (19:21 +0000)
committerTeresa Johnson <tejohnson@google.com>
Mon, 14 Nov 2016 19:21:41 +0000 (19:21 +0000)
commit52fb4f34b6f595c9995d5cc5884c27e398205780
tree240d59e37e0217f0006942810ad9185b14c2dfd4
parent43aeb78cb8068723e61f6cb832cd008d3efe8401
[ThinLTO] Only promote exported locals as marked in index

Summary:
We have always speculatively promoted all renamable local values
(except const non-address taken variables) for both the exporting
and importing module. We would then internalize them back based on
the ThinLink results if they weren't actually exported. This is
inefficient, and results in unnecessary renames. It also meant we
had to check the non-renamability of a value in the summary, which
was already checked during function importing analysis in the ThinLink.

Made renameModuleForThinLTO (which does the promotion/renaming) instead
use the index when exporting, to avoid unnecessary renames/promotions.
For importing modules, we can simply promoted all values as any local
we import by definition is exported and needs promotion.

This required changes to the method used by the FunctionImport pass
(only invoked from 'opt' for testing) and when invoked from llvm-link,
since neither does a ThinLink. We simply conservatively mark all locals
in the index as promoted, which preserves the current aggressive
promotion behavior.

I also needed to change an llvm-lto based test where we had previously
been aggressively promoting values that weren't importable (aliasees),
but now will not promote.

Reviewers: mehdi_amini

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D26467

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@286871 91177308-0d34-0410-b5e6-96231b3b80d8
lib/LTO/ThinLTOCodeGenerator.cpp
lib/Transforms/IPO/FunctionImport.cpp
lib/Transforms/Utils/FunctionImportUtils.cpp
test/ThinLTO/X86/alias_import.ll
tools/llvm-link/llvm-link.cpp