]> granicus.if.org Git - postgresql/commit
Ensure pg_ctl behaves sanely when data directory is not specified.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 12 Jun 2012 02:47:16 +0000 (22:47 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 12 Jun 2012 02:47:16 +0000 (22:47 -0400)
commit51e61b04f8040f627e7605594095b06c10582fd0
treeadd9df96d89ff138c20bd56ffdebf733094b3b51
parentbf0945e8636bf0390ef4569bbbf9763573211e03
Ensure pg_ctl behaves sanely when data directory is not specified.

Commit aaa6e1def292cdacb6b27088898793b1b879fedf introduced multiple hazards
in the case where pg_ctl is executed with neither a -D switch nor any
PGDATA environment variable.  It would dump core on machines which are
unforgiving about printf("%s", NULL), or failing that possibly give a
rather unhelpful complaint about being unable to execute "postgres -C",
rather than the logically prior complaint about not being told where the
data directory is.

Edmund Horner's report suggests that there is another, Windows-specific
hazard here, but I'm not the person to fix that; it would in any case only
be significant when trying to use a config-only PGDATA pointer.
src/bin/pg_ctl/pg_ctl.c