]> granicus.if.org Git - postgresql/commit
Improve division of labor between execParallel.c and nodeGather[Merge].c.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 1 Sep 2017 21:38:54 +0000 (17:38 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 1 Sep 2017 21:39:01 +0000 (17:39 -0400)
commit51daa7bdb39e1bdc31eb99fd3f54f61743ebb7ae
treea527c43c5129b7f154b32326337e062202c04010
parentc039ba0716383ccaf88c9be1a7f0803a77823de1
Improve division of labor between execParallel.c and nodeGather[Merge].c.

Move the responsibility for creating/destroying TupleQueueReaders into
execParallel.c, to avoid duplicative coding in nodeGather.c and
nodeGatherMerge.c.  Also, instead of having DestroyTupleQueueReader do
shm_mq_detach, do it in the caller (which is now only ExecParallelFinish).
This means execParallel.c does both the attaching and detaching of the
tuple-queue-reader shm_mqs, which seems less weird than the previous
arrangement.

These changes also eliminate a vestigial memory leak (of the pei->tqueue
array).  It's now demonstrable that rescans of Gather or GatherMerge don't
leak memory.

Discussion: https://postgr.es/m/8670.1504192177@sss.pgh.pa.us
src/backend/executor/execParallel.c
src/backend/executor/nodeGather.c
src/backend/executor/nodeGatherMerge.c
src/backend/executor/tqueue.c
src/include/executor/execParallel.h