]> granicus.if.org Git - postgresql/commit
Move isolationtester's is-blocked query into C code for speed.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 10 Apr 2017 14:26:54 +0000 (10:26 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 10 Apr 2017 14:26:54 +0000 (10:26 -0400)
commit511540dadf1166d80b864f63979178f324844060
treeb020d15352b84a5482c5b5064d6cd84793b1bdb8
parent9cf5c31964315181e475fc37a5e9ad2204fe3484
Move isolationtester's is-blocked query into C code for speed.

Commit 4deb41381 modified isolationtester's query to see whether a
session is blocked to also check for waits occurring in GetSafeSnapshot.
However, it did that in a way that enormously increased the query's
runtime under CLOBBER_CACHE_ALWAYS, causing the buildfarm members
that use that to run about four times slower than before, and in some
cases fail entirely.  To fix, push the entire logic into a dedicated
backend function.  This should actually reduce the CLOBBER_CACHE_ALWAYS
runtime from what it was previously, though I've not checked that.

In passing, expose a SQL function to check for safe-snapshot blockage,
comparable to pg_blocking_pids.  This is more or less free given the
infrastructure built to solve the other problem, so we might as well.

Thomas Munro

Discussion: https://postgr.es/m/20170407165749.pstcakbc637opkax@alap3.anarazel.de
doc/src/sgml/func.sgml
src/backend/storage/lmgr/predicate.c
src/backend/utils/adt/lockfuncs.c
src/include/catalog/catversion.h
src/include/catalog/pg_proc.h
src/include/storage/predicate_internals.h
src/test/isolation/.gitignore
src/test/isolation/isolationtester.c