]> granicus.if.org Git - postgresql/commit
Make dblink try harder to form useful error messages
authorJoe Conway <mail@joeconway.com>
Thu, 22 Dec 2016 17:47:55 +0000 (09:47 -0800)
committerJoe Conway <mail@joeconway.com>
Thu, 22 Dec 2016 17:47:55 +0000 (09:47 -0800)
commit51126ccdb1ce720b674405e11bcb5e7b8fa902fb
tree6bce268ffa8a9bc0002f93218f293723c3ee5ae4
parent150841fb94f651a8e452d7a452c3225c2dafdf16
Make dblink try harder to form useful error messages

When libpq encounters a connection-level error, e.g. runs out of memory
while forming a result, there will be no error associated with PGresult,
but a message will be placed into PGconn's error buffer. postgres_fdw
takes care to use the PGconn error message when PGresult does not have
one, but dblink has been negligent in that regard. Modify dblink to mirror
what postgres_fdw has been doing.

Back-patch to all supported branches.

Author: Joe Conway
Reviewed-By: Tom Lane
Discussion: https://postgr.es/m/02fa2d90-2efd-00bc-fefc-c23c00eb671e%40joeconway.com
contrib/dblink/dblink.c