]> granicus.if.org Git - postgresql/commit
Fix deadlock in heap_compute_xid_horizon_for_tuples().
authorThomas Munro <tmunro@postgresql.org>
Mon, 1 Apr 2019 20:08:15 +0000 (09:08 +1300)
committerThomas Munro <tmunro@postgresql.org>
Mon, 1 Apr 2019 20:29:49 +0000 (09:29 +1300)
commit4fd05bb55b40a3c9dde2b19942f275fc31b5225a
treee8700cb27e39c63b4cb1f35da1434cfca722bb3d
parent12d46ac392d00fa0d103f445aa4997f97029e007
Fix deadlock in heap_compute_xid_horizon_for_tuples().

We can't call code that uses syscache while we hold buffer locks
on a catalog relation.  If passed such a relation, just fall back
to the general effective_io_concurrency GUC rather than trying to
look up the containing tablespace's IO concurrency setting.

We might find a better way to control prefetching in follow-up
work, but for now this is enough to avoid the deadlock introduced
by commit 558a9165e0.

Reviewed-by: Andres Freund
Diagnosed-by: Peter Geoghegan
Discussion: https://postgr.es/m/CA%2BhUKGLCwPF0S4Mk7S8qw%2BDK0Bq65LueN9rofAA3HHSYikW-Zw%40mail.gmail.com
Discussion: https://postgr.es/m/962831d8-c18d-180d-75fb-8b842e3a2742%40chrullrich.net
src/backend/access/heap/heapam.c