]> granicus.if.org Git - postgresql/commit
Always pass catalog id to the options validator function specified in
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Wed, 23 Dec 2009 12:23:59 +0000 (12:23 +0000)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Wed, 23 Dec 2009 12:23:59 +0000 (12:23 +0000)
commit4e766f2d176af92a8372b28a9ec2aa1eb8083063
tree9b61b7489abe228b19aa85c4ad1ce408afa527e5
parentb683908064e1fa4db26348ca43081dc6a99e3e4e
Always pass catalog id to the options validator function specified in
CREATE FOREIGN DATA WRAPPER. Arguably it wasn't a bug because the
documentation said that it's passed the catalog ID or zero, but surely
we should provide it when it's known. And there isn't currently any
scenario where it's not known, and I can't imagine having one in the
future either, so better remove the "or zero" escape hatch and always
pass a valid catalog ID. Backpatch to 8.4.

Martin Pihlak
doc/src/sgml/ref/create_foreign_data_wrapper.sgml
src/backend/commands/foreigncmds.c
src/backend/foreign/foreign.c
src/test/regress/expected/foreign_data.out