]> granicus.if.org Git - python/commit
When range checking was added to time.strftime() a check was placed on tm_isdst
authorBrett Cannon <bcannon@gmail.com>
Tue, 22 Sep 2009 00:29:48 +0000 (00:29 +0000)
committerBrett Cannon <bcannon@gmail.com>
Tue, 22 Sep 2009 00:29:48 +0000 (00:29 +0000)
commit4d94743c28af939864e870f556f8b656fbd3b774
tree92d6e417f15caff24e5f2d433fae20701c012068
parent2a46658beef7de998dfcf85ca5e9ddf97f63a8bf
When range checking was added to time.strftime() a check was placed on tm_isdst
to make sure it fell within [-1, 1] just in case someone implementing
strftime() in libc was stupid enough to assume this. Turns out, though, some
OSs (e.g. zOS) are stupid enough to use values outside of this range for time
structs created by the system itself. So instead of throwing a ValueError,
tm_isdst is now normalized before being passed to strftime().

Fixes issue #6823. Thanks Robert Shapiro for diagnosing the problem and
contributing an initial patch.
Lib/test/test_time.py
Misc/ACKS
Misc/NEWS
Modules/timemodule.c