]> granicus.if.org Git - postgresql/commit
Fix broken Assert() introduced by 8e9a16ab8f7f0e58
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Fri, 27 Jun 2014 18:43:39 +0000 (14:43 -0400)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Fri, 27 Jun 2014 18:43:39 +0000 (14:43 -0400)
commit4c888a6290add7ab86078c8759f0de1bd74c7377
tree07b3ff9852d05c500fa3fe15847a6f483a06f4f5
parent6327f25dddba0c359f8be8395e1b2d99dfe0d30c
Fix broken Assert() introduced by 8e9a16ab8f7f0e58

Don't assert MultiXactIdIsRunning if the multi came from a tuple that
had been share-locked and later copied over to the new cluster by
pg_upgrade.  Doing that causes an error to be raised unnecessarily:
MultiXactIdIsRunning is not open to the possibility that its argument
came from a pg_upgraded tuple, and all its other callers are already
checking; but such multis cannot, obviously, have transactions still
running, so the assert is pointless.

Noticed while investigating the bogus pg_multixact/offsets/0000 file
left over by pg_upgrade, as reported by Andres Freund in
http://www.postgresql.org/message-id/20140530121631.GE25431@alap3.anarazel.de

Backpatch to 9.3, as the commit that introduced the buglet.
src/backend/access/heap/heapam.c