]> granicus.if.org Git - postgresql/commit
projects / postgresql / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 05dc5f4) | patch
Don't read fields of a misaligned ExpandedObjectHeader or AnyArrayType.
authorNoah Misch <noah@leadboat.com>
Mon, 1 Jul 2019 00:34:17 +0000 (17:34 -0700)
committerNoah Misch <noah@leadboat.com>
Mon, 1 Jul 2019 00:34:20 +0000 (17:34 -0700)
commit4b85f20f948d885875a1e1b89979e627b86e6e64
tree218eca7bdfa2a0588848528ddb468438fef7f581tree | snapshot
parent05dc5f4767e1c5ed157b2870f05d57f3378302f4commit | diff
Don't read fields of a misaligned ExpandedObjectHeader or AnyArrayType.

UBSan complains about this.  Instead, cast to a suitable type requiring
only 4-byte alignment.  DatumGetAnyArrayP() already assumes one can cast
between AnyArrayType and ArrayType, so this doesn't introduce a new
assumption.  Back-patch to 9.5, where AnyArrayType was introduced.

Reviewed by Tom Lane.

Discussion: https://postgr.es/m/20190629210334.GA1244217@rfd.leadboat.com
src/backend/utils/adt/arrayfuncs.c diff | blob | history
src/include/utils/array.h diff | blob | history
src/include/utils/arrayaccess.h diff | blob | history
src/include/utils/expandeddatum.h diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.