]> granicus.if.org Git - python/commit
Forward-port of r52136: a review of overflow-detecting code.
authorArmin Rigo <arigo@tunes.org>
Wed, 4 Oct 2006 11:44:06 +0000 (11:44 +0000)
committerArmin Rigo <arigo@tunes.org>
Wed, 4 Oct 2006 11:44:06 +0000 (11:44 +0000)
commit4b63c21d6faebc406260733c16b826e3e01b0d89
treebdeaa6389ccc7075550272904869d32302046572
parentc6f2f884b4789c4000ffb30a85646f088da102b1
Forward-port of r52136: a review of overflow-detecting code.

* unified the way intobject, longobject and mystrtoul handle
  values around -sys.maxint-1.

* in general, trying to entierely avoid overflows in any computation
  involving signed ints or longs is extremely involved.  Fixed a few
  simple cases where a compiler might be too clever (but that's all
  guesswork).

* more overflow checks against bad data in marshal.c.

* 2.5 specific: fixed a number of places that were still confusing int
  and Py_ssize_t.  Some of them could potentially have caused
  "real-world" breakage.

* list.pop(x): fixing overflow issues on x was messy.  I just reverted
  to PyArg_ParseTuple("n"), which does the right thing.  (An obscure
  test was trying to give a Decimal to list.pop()... doesn't make
  sense any more IMHO)

* trying to write a few tests...
19 files changed:
Lib/test/list_tests.py
Lib/test/test_builtin.py
Lib/test/test_long.py
Misc/NEWS
Modules/cPickle.c
Objects/abstract.c
Objects/fileobject.c
Objects/intobject.c
Objects/listobject.c
Objects/longobject.c
Objects/stringobject.c
Objects/typeobject.c
Objects/unicodeobject.c
Python/errors.c
Python/getargs.c
Python/marshal.c
Python/modsupport.c
Python/mystrtoul.c
Python/sysmodule.c