]> granicus.if.org Git - postgresql/commit
Solve cross-version-upgrade testing problem induced by 1fb57af92.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 10 Feb 2019 02:02:06 +0000 (21:02 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 10 Feb 2019 02:02:06 +0000 (21:02 -0500)
commit4b235947c7c63a084a90c2e049d79a09ff03b9b3
treeec8f683b9cfd1aa59758414adef0f6f28c30b733
parent2b6009e2a2794df286939e5ce1196a23cca07d68
Solve cross-version-upgrade testing problem induced by 1fb57af92.

Renaming varchar_transform to varchar_support had a side effect
I hadn't foreseen: the core regression tests leave around a
transform object that relies on that function, so the name
change breaks cross-version upgrade tests, because the name
used in the older branches doesn't match.

Since the dependency on varchar_transform was chosen with the
aid of a dartboard anyway (it would surely not work as a
language transform support function), fix by just choosing
a different random builtin function with the right signature.
Also add some comments explaining why this isn't horribly unsafe.

I chose to make the same substitution in a couple of other
copied-and-pasted test cases, for consistency, though those
aren't directly contributing to the testing problem.

Per buildfarm.  Back-patch, else it doesn't fix the problem.
src/bin/pg_dump/t/002_pg_dump.pl
src/test/modules/test_ddl_deparse/expected/create_transform.out
src/test/modules/test_ddl_deparse/sql/create_transform.sql
src/test/regress/expected/object_address.out
src/test/regress/sql/object_address.sql