]> granicus.if.org Git - postgresql/commit
Fix bogus logic for checking data dirs' versions within pg_upgrade.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 16 Nov 2017 16:16:53 +0000 (11:16 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 16 Nov 2017 16:16:53 +0000 (11:16 -0500)
commit4b02e935fee881eab1f4fabdbebccedfa57b4ddd
tree309edbdcb04dae0693e7bf9274e163355076b687
parent619a8c47da7279c186bb57cc16b26ad011366b73
Fix bogus logic for checking data dirs' versions within pg_upgrade.

Commit 9be95ef15 failed to cure all of the redundancy here: we were
actually calling get_major_server_version() three times for each
of the old and new data directories.  While that's not enormously
expensive, it's still sloppy.

A. Akenteva

Discussion: https://postgr.es/m/f9266a85d918a3cf3a386b5148aee666@postgrespro.ru
src/bin/pg_upgrade/check.c
src/bin/pg_upgrade/exec.c