]> granicus.if.org Git - postgresql/commit
Fix SxactGlobalXmin tracking.
authorThomas Munro <tmunro@postgresql.org>
Thu, 9 May 2019 07:11:46 +0000 (19:11 +1200)
committerThomas Munro <tmunro@postgresql.org>
Thu, 9 May 2019 08:32:26 +0000 (20:32 +1200)
commit47a338cfcd67139a1f91892b080934fcfc3aea03
tree2e5559d4d29abf569b96dfba55130091bf69c5ce
parentcd805f46d857291b26ba6eb491ce11b6e0fc9ad3
Fix SxactGlobalXmin tracking.

Commit bb16aba50 broke the code that maintains SxactGlobalXmin.  It
could get stuck when a well-timed READ ONLY transaction runs.  If
SxactGlobalXmin stops advancing, transactions on the
FinishedSerializableTransactions queue are never cleaned up, so
resources are effectively leaked.  Revert that hunk of the commit.

Also revert another similar hunk that was probably harmless, but
unnecessary and unjustified, relating to the DOOMED flag in case of
RO_SAFE early release.

Author: Thomas Munro
Reported-by: Tom Lane
Discussion: https://postgr.es/m/16170.1557251214%40sss.pgh.pa.us
src/backend/storage/lmgr/predicate.c