]> granicus.if.org Git - postgresql/commit
Make gistvacuumcleanup() count the actual number of index tuples.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 2 Mar 2018 16:22:42 +0000 (11:22 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 2 Mar 2018 16:22:42 +0000 (11:22 -0500)
commit46d98da43e56aa407242fc5ca6c0303f160cd936
tree8fab38c0c04639f2774a8d61faf72e948064f94e
parentfb1d72f409497a8e217f877184ff1e0056e1394e
Make gistvacuumcleanup() count the actual number of index tuples.

Previously, it just returned the heap tuple count, which might be only an
estimate, and would be completely the wrong thing if the index is partial.
Since this function scans every index page anyway to find free pages,
it's practically free to count the surviving index tuples.  Let's do that
and return an accurate count.

This is easily visible as a wrong reltuples value for a partial GiST
index following VACUUM, so back-patch to all supported branches.

Andrey Borodin, reviewed by Michail Nikolaev

Discussion: https://postgr.es/m/151956654251.6915.675951950408204404.pgcf@coridan.postgresql.org
src/backend/access/gist/gistvacuum.c