]> granicus.if.org Git - postgresql/commit
Avoid early reuse of btree pages, causing incorrect query results.
authorSimon Riggs <simon@2ndQuadrant.com>
Fri, 1 Jun 2012 11:47:01 +0000 (12:47 +0100)
committerSimon Riggs <simon@2ndQuadrant.com>
Fri, 1 Jun 2012 11:47:01 +0000 (12:47 +0100)
commit46ceb398f09e0bd8427b73350d48e414f4372153
treede2df31a2b074a30c1a3e4e6e56364b611651474
parent8c9f2dc67084986332dc1eaf7228461ff1f2d9a6
Avoid early reuse of btree pages, causing incorrect query results.
When we allowed read-only transactions to skip assigning XIDs
we introduced the possibility that a fully deleted btree page
could be reused. This broke the index link sequence which could
then lead to indexscans silently returning fewer rows than would
have been correct. The actual incidence of silent errors from
this is thought to be very low because of the exact workload
required and locking pre-conditions. Fix is to remove pages only
if index page opaque->btpo.xact precedes RecentGlobalXmin.

Noah Misch, reviewed and backpatched by Simon Riggs
src/backend/access/nbtree/README
src/backend/access/nbtree/nbtpage.c