]> granicus.if.org Git - postgresql/commit
Revert "Distinguish printf-like functions that support %m from those that don't."
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 12 Aug 2018 22:46:01 +0000 (18:46 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 12 Aug 2018 22:46:01 +0000 (18:46 -0400)
commit46b5e7c4b5befbf6ac86d827a3a58f1f02c7338e
treed650f4d3293ec1d27961b17baa7cb5a020a973d7
parentd11eae09e48694ad6b4139bbb7d7b112833301f5
Revert "Distinguish printf-like functions that support %m from those that don't."

This reverts commit 3a60c8ff892a8242b907f44702bfd9f1ff877d45.  Buildfarm
results show that that caused a whole bunch of new warnings on platforms
where gcc believes the local printf to be non-POSIX-compliant.  This
problem outweighs the hypothetical-anyway possibility of getting warnings
for misuse of %m.  We could use gnu_printf archetype when we've substituted
src/port/snprintf.c, but that brings us right back to the problem of not
getting warnings for %m.

A possible answer is to attack it in the other direction by insisting
that %m support be included in printf's feature set, but that will take
more investigation.  In the meantime, revert the previous change, and
update the comment for PGAC_C_PRINTF_ARCHETYPE to more fully explain
what's going on.

Discussion: https://postgr.es/m/2975.1526862605@sss.pgh.pa.us
config/c-compiler.m4
configure
src/include/c.h
src/include/pg_config.h.in
src/include/utils/elog.h