]> granicus.if.org Git - postgresql/commit
Make CREATE TYPE print warnings if a datatype's I/O functions are volatile.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 5 Nov 2014 16:44:06 +0000 (11:44 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 5 Nov 2014 16:44:06 +0000 (11:44 -0500)
commit465d7e1882bc1f316c7cb2a68e751c34b403e8d7
tree713872e67d291707652f980224eb7ff896c6fb03
parent66c029c842629958b3ae0d389f24ea3407225723
Make CREATE TYPE print warnings if a datatype's I/O functions are volatile.

This is a followup to commit 43ac12c6e6e397fd9142ed908447eba32d3785b2,
which added regression tests checking that I/O functions of built-in
types are not marked volatile.  Complaining in CREATE TYPE should push
developers of add-on types to fix any misdeclared functions in their
types.  It's just a warning not an error, to avoid creating upgrade
problems for what might be just cosmetic mis-markings.

Aside from adding the warning code, fix a number of types that were
sloppily created in the regression tests.
src/backend/commands/typecmds.c
src/test/regress/expected/create_cast.out
src/test/regress/expected/create_type.out
src/test/regress/input/create_function_1.source
src/test/regress/output/create_function_1.source
src/test/regress/sql/create_cast.sql
src/test/regress/sql/create_type.sql