]> granicus.if.org Git - php/commit
Revert "Make BG(syslog_device) per request"
authorNikita Popov <nikita.ppv@gmail.com>
Thu, 30 Jan 2020 15:18:02 +0000 (16:18 +0100)
committerNikita Popov <nikita.ppv@gmail.com>
Thu, 30 Jan 2020 15:18:02 +0000 (16:18 +0100)
commit453713868fa6e5bf0785c2f33e0b4415166418e6
tree8600b8b6585673b752a510a3126496ea86810f16
parent981fdd9f51b352045f9b1f2cdc650f0f5dd9695c
Revert "Make BG(syslog_device) per request"

This reverts commit b0d7b126a29a1972229ac91d6d28f5331912eddb.

This change wasn't quite right: I noticed only now that the
RSHUTDOWN function is #ifdef PHP_WIN32 and I'm not fully convinced
that ifdef can be removed: syslog might also be used by error
logging in FPM for example, in which case we probably shouldn't
be closing the log here.

Generally it's unclear how the openlog() functionality exposed
by PHP is supposed to interact with openlog() uses by SAPIs.

For now I'll just revert this change and let it leak across
requests.
ext/standard/syslog.c