]> granicus.if.org Git - llvm/commit
[GN] Generation failure caused by trailing space in file name
authorPetr Hosek <phosek@chromium.org>
Sun, 23 Jun 2019 23:12:10 +0000 (23:12 +0000)
committerPetr Hosek <phosek@chromium.org>
Sun, 23 Jun 2019 23:12:10 +0000 (23:12 +0000)
commit43f3f953950c4a51208ba96afda6b4fa1d83f5c8
tree2fb68d9495d464ed13d59580900b4c6ce9cf7b39
parent5fae5e00b26a33fcdc2c350ddbe5b0bc36b67ea6
[GN] Generation failure caused by trailing space in file name

When I executed gn.py gen out/gn I got the following error:

ERROR at //compiler-rt/lib/builtins/BUILD.gn:162:7: Only source, header, and object files belong in the sources of a static_library. //compiler-rt/lib/builtins/emutls.c  is not one of the valid types.
      "emutls.c ",
      ^----------
See //compiler-rt/lib/BUILD.gn:3:5: which caused the file to be included.
    "//compiler-rt/lib/builtins",
    ^---------------------------
It turns out to be that the latest gn doesn't accept ill-format file name. And the emutls.c above has a trailing space.
Remove the trailing space should work.

Patch By: myhsu
Differential Revision: https://reviews.llvm.org/D63449

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@364162 91177308-0d34-0410-b5e6-96231b3b80d8
utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn