]> granicus.if.org Git - postgresql/commit
Fix some oversights in BRIN patch.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 21 Jul 2015 17:38:24 +0000 (13:38 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 21 Jul 2015 17:38:24 +0000 (13:38 -0400)
commit434873806a9b1c0edd53c2a9df7c93a8ba021147
tree660417bfb69595f70323cb3c81c45e6b757dee27
parent9faa6ae14f6098e4b55f0131f7ec2694a381fb87
Fix some oversights in BRIN patch.

Remove HeapScanDescData.rs_initblock, which wasn't being used for anything
in the final version of the patch.

Fix IndexBuildHeapScan so that it supports syncscan again; the patch
broke synchronous scanning for index builds by forcing rs_startblk
to zero even when the caller did not care about that and had asked
for syncscan.

Add some commentary and usage defenses to heap_setscanlimits().

Fix heapam so that asking for rs_numblocks == 0 does what you would
reasonably expect.  As coded it amounted to requesting a whole-table
scan, because those "--x <= 0" tests on an unsigned variable would
behave surprisingly.
src/backend/access/heap/heapam.c
src/backend/catalog/index.c
src/include/access/relscan.h