]> granicus.if.org Git - postgresql/commit
Truncate strings in tarCreateHeader() with strlcpy(), not sprintf().
authorNoah Misch <noah@leadboat.com>
Mon, 22 Jun 2015 00:04:36 +0000 (20:04 -0400)
committerNoah Misch <noah@leadboat.com>
Mon, 22 Jun 2015 00:04:36 +0000 (20:04 -0400)
commit4318118edd5582696027f357771e0a8b091fe2bf
tree140dda22ddd37a99dcce70ddb6d1f84ebf9c8c7d
parentad89a5d115b3b4025f3c135f95f722e7e4becf13
Truncate strings in tarCreateHeader() with strlcpy(), not sprintf().

This supplements the GNU libc bug #6530 workarounds introduced in commit
54cd4f04576833abc394e131288bf3dd7dcf4806.  On affected systems, a
tar-format pg_basebackup failed when some filename beneath the data
directory was not valid character data in the postmaster/walsender
locale.  Back-patch to 9.1, where pg_basebackup was introduced.  Extant,
bug-prone conversion specifications receive only ASCII bytes or involve
low-importance messages.
src/bin/pg_basebackup/t/010_pg_basebackup.pl
src/port/tar.c