]> granicus.if.org Git - postgresql/commit
Prevent failure when RowExpr or XmlExpr is parse-analyzed twice.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 23 Dec 2012 19:07:52 +0000 (14:07 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 23 Dec 2012 19:07:52 +0000 (14:07 -0500)
commit4297f1732f7bf8f45f81a5e996d8333f2863a3d3
tree4889ba902ecb8866b6f2ed5701d1f98f9d39e3e8
parent3fd03932fcbfcd94a4aca9ffdcecdddbc1a8c9a1
Prevent failure when RowExpr or XmlExpr is parse-analyzed twice.

transformExpr() is required to cope with already-transformed expression
trees, for various ugly-but-not-quite-worth-cleaning-up reasons.  However,
some of its newer subroutines hadn't gotten the memo.  This accounts for
bug #7763 from Norbert Buchmuller: transformRowExpr() was overwriting the
previously determined type of a RowExpr during CREATE TABLE LIKE INCLUDING
INDEXES.  Additional investigation showed that transformXmlExpr had the
same kind of problem, but all the other cases seem to be safe.

Andres Freund and Tom Lane
src/backend/parser/gram.y
src/backend/parser/parse_expr.c