]> granicus.if.org Git - postgresql/commit
Fix possible crash due to incorrect allocation context.
authorRobert Haas <rhaas@postgresql.org>
Tue, 16 Aug 2016 17:23:32 +0000 (13:23 -0400)
committerRobert Haas <rhaas@postgresql.org>
Tue, 16 Aug 2016 17:23:32 +0000 (13:23 -0400)
commit41fb35fabf03bffa812caddf24323d4d06f811ba
treef110b59ba635a6a074854e763a4ad60336dbb71d
parenta7b5573d665c8a37fad9bc69f44c5b4e8760a73b
Fix possible crash due to incorrect allocation context.

Commit af33039317ddc4a0e38a02e2255c2bf453115fd2 aimed to reduce
leakage from tqueue.c, which is good.  Unfortunately, by changing the
memory context in which all of gather_readnext() executes, it also
changed the context in which ExecShutdownGatherWorkers executes, which
is not good, because that function eventually causes a call to
ExecParallelRetrieveInstrumentation, which proceeds to allocate
planstate->worker_instrument in a short-lived context, causing a
crash.

Rushabh Lathia, reviewed by Amit Kapila and by me.
src/backend/executor/execParallel.c