]> granicus.if.org Git - postgresql/commit
pg_rewind: fsync target data directory.
authorAndres Freund <andres@anarazel.de>
Sun, 27 Mar 2016 21:46:25 +0000 (23:46 +0200)
committerAndres Freund <andres@anarazel.de>
Sun, 27 Mar 2016 21:46:25 +0000 (23:46 +0200)
commit408f0438531eec17ac62f91fc23f72bcfc48dd36
tree937662049f1a171ddcf63048bdcadb87da8da260
parent9f7c527af308dcdaba2f0ff9d362d672e8886fb1
pg_rewind: fsync target data directory.

Previously pg_rewind did not fsync any files. That's problematic, given
that the target directory is modified. If the database was started
afterwards, 2ce439f33 luckily already caused the data directory to be
synced to disk at postmaster startup; reducing the scope of the problem.

To fix, use initdb -S, at the end of the pg_rewind run. It doesn't seem
worthwhile to duplicate the code into pg_rewind, and initdb -S is
already used that way by pg_upgrade.

Reported-By: Andres Freund
Author: Michael Paquier, somewhat edited by me
Discussion: 20160310034352.iuqgvpmg5qmnxtkz@alap3.anarazel.de
    CAB7nPqSytVG1o4S3S2pA1O=692ekurJ+fckW2PywEG3sNw54Ow@mail.gmail.com
Backpatch: 9.5, where pg_rewind was introduced
src/bin/pg_rewind/file_ops.c
src/bin/pg_rewind/pg_rewind.c