]> granicus.if.org Git - procps-ng/commit
projects / procps-ng / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 18efff2) | patch
0026-skill: Fix double-increment of pid_count.
authorQualys Security Advisory <qsa@qualys.com>
Thu, 1 Jan 1970 00:00:00 +0000 (00:00 +0000)
committerCraig Small <csmall@enc.com.au>
Sat, 23 Jun 2018 11:59:14 +0000 (21:59 +1000)
commit3f75d105b9405664f3db2958bdecf298ea15a5c2
treeb42ac2a4f2addbcff16ca8a607cff0d487f9b8d9tree | snapshot
parent18efff2a1f0786e8309faf785db0a2cada2bbe38commit | diff
0026-skill: Fix double-increment of pid_count.

No need to "pid_count++;" because "ENLIST(pid," does it already. Right
now this can trigger a heap-based buffer overflow.

Also, remove the unneeded "pid_count = 0;" (it is static, and
skillsnice_parse() is called only once; and the other *_count variables
are not initialized explicitly either).
skill.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.