]> granicus.if.org Git - postgresql/commit
Fix end-of-loop optimization in pglz_find_match() function.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Wed, 17 Jul 2013 17:24:28 +0000 (20:24 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Wed, 17 Jul 2013 17:37:09 +0000 (20:37 +0300)
commit3f2adace1ec025908b5189f0773b4eaab3d228d5
treee2d01bec6ce78b1a59b079e76ff3f67569a0e35a
parent750f43685b1b88d4281074940cdcea0e328593aa
Fix end-of-loop optimization in pglz_find_match() function.

After the recent pglz optimization patch, the next/prev pointers in the
hash table are never NULL, INVALID_ENTRY_PTR is used to represent invalid
entries instead. The end-of-loop check in pglz_find_match() function didn't
get the memo. The result was the same from a correctness point of view, but
because the NULL-check would never fail, the tiny optimization turned into
a pessimization.

Reported by Stephen Frost, using Coverity scanner.
src/backend/utils/adt/pg_lzcompress.c