]> granicus.if.org Git - clang/commit
[CodeGen] add rotate builtins
authorSanjay Patel <spatel@rotateright.com>
Sun, 19 Aug 2018 13:12:40 +0000 (13:12 +0000)
committerSanjay Patel <spatel@rotateright.com>
Sun, 19 Aug 2018 13:12:40 +0000 (13:12 +0000)
commit3d796ad14a933a66a312384da4219bd611468ce4
tree43991cc5f61a3c05068be10fe5ffbe7b0b82120d
parente6554b83e1b0d110f74b77594770e483dcc62e4f
[CodeGen] add rotate builtins

This exposes the LLVM funnel shift intrinsics as more familiar bit rotation functions in clang
(when both halves of a funnel shift are the same value, it's a rotate).

We're free to name these as we want because we're not copying gcc, but if there's some other
existing art (eg, the microsoft ops that are modified in this patch) that we want to replicate,
we can change the names.

The funnel shift intrinsics were added here:
D49242

With improved codegen in:
rL337966
rL339359

And basic IR optimization added in:
rL338218
rL340022

...so these are expected to produce asm output that's equal or better to the multi-instruction
alternatives using primitive C/IR ops.

In the motivating loop example from PR37387:
https://bugs.llvm.org/show_bug.cgi?id=37387#c7
...we get the expected 'rolq' x86 instructions if we substitute the rotate builtin into the source.

Differential Revision: https://reviews.llvm.org/D50924

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@340135 91177308-0d34-0410-b5e6-96231b3b80d8
docs/LanguageExtensions.rst
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtin-rotate.c [new file with mode: 0644]
test/CodeGen/ms-intrinsics-rotations.c