]> granicus.if.org Git - postgresql/commit
Fix logical replication's ideas about which type OIDs are built-in.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 13 May 2019 21:23:00 +0000 (17:23 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 13 May 2019 21:23:00 +0000 (17:23 -0400)
commit3b505036a129af5bbbf40a00f8997fc15438bb38
tree18877e6ad0a4cf1aae0345f0321ec32e3457f71d
parente3bf3c0f8c9c880ba808bc11c2825ecba720e4ed
Fix logical replication's ideas about which type OIDs are built-in.

Only hand-assigned type OIDs should be presumed to match across different
PG servers; those assigned during genbki.pl or during initdb are likely
to change due to addition or removal of unrelated objects.

This means that the cutoff should be FirstGenbkiObjectId (in HEAD)
or FirstBootstrapObjectId (before that), not FirstNormalObjectId.
Compare postgres_fdw's is_builtin() test.

It's likely that this error has no observable consequence in a
normally-functioning system, since ATM the only affected type OIDs are
system catalog rowtypes and information_schema types, which would not
typically be interesting for logical replication.  But you could
probably break it if you tried hard, so back-patch.

Discussion: https://postgr.es/m/15150.1557257111@sss.pgh.pa.us
src/backend/replication/logical/relation.c
src/backend/replication/pgoutput/pgoutput.c