]> granicus.if.org Git - postgresql/commit
Fix incorrect computations of length of null bitmap in pageinspect.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 4 Jan 2018 19:59:00 +0000 (14:59 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 4 Jan 2018 19:59:00 +0000 (14:59 -0500)
commit39cfe86195f0b5cbc5fbe8d4e3aa6e2b0e322d0b
tree09cbadfd4f1ebf98129a308cecd4f598331e4de8
parentf3049a603a7950f313b33ab214f11563c66dc069
Fix incorrect computations of length of null bitmap in pageinspect.

Instead of using our standard macro for this calculation, this code
did it itself ... and got it wrong, leading to incorrect display of
the null bitmap in some cases.  Noted and fixed by Maksim Milyutin.

In passing, remove a uselessly duplicative error check.

Errors were introduced in commit d6061f83a; back-patch to 9.6
where that came in.

Maksim Milyutin, reviewed by Andrey Borodin

Discussion: https://postgr.es/m/ec295792-a69f-350f-6287-25a20e8f31d5@gmail.com
contrib/pageinspect/expected/page.out
contrib/pageinspect/heapfuncs.c
contrib/pageinspect/sql/page.sql