]> granicus.if.org Git - python/commit
bpo-36871: Ensure method signature is used when asserting mock calls to a method...
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Thu, 29 Aug 2019 06:58:27 +0000 (23:58 -0700)
committerChris Withers <chris@withers.org>
Thu, 29 Aug 2019 06:58:27 +0000 (07:58 +0100)
commit38d311d79e57479f7a684c2cd298293033dc4990
treee942b90e6c736218104e2a06e47b6528f7c09637
parent612d3935ec0b2fbe88b3fae8167f0c503c61a9ca
bpo-36871: Ensure method signature is used when asserting mock calls to a method (GH15578)

* Fix call_matcher for mock when using methods

* Add NEWS entry

* Use None check and convert doctest to unittest

* Use better name for mock in tests. Handle _SpecState when the attribute was not accessed and add tests.

* Use reset_mock instead of reinitialization. Change inner class constructor signature for check

* Reword comment regarding call object lookup logic
(cherry picked from commit c96127821ebda50760e788b1213975a0d5bea37f)

Co-authored-by: Xtreak <tir.karthi@gmail.com>
Lib/unittest/mock.py
Lib/unittest/test/testmock/testmock.py
Misc/NEWS.d/next/Library/2019-05-12-12-58-37.bpo-36871.6xiEHZ.rst [new file with mode: 0644]