]> granicus.if.org Git - postgresql/commit
Support domains over composite types.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 26 Oct 2017 17:47:45 +0000 (13:47 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 26 Oct 2017 17:47:45 +0000 (13:47 -0400)
commit37a795a60b4f4b1def11c615525ec5e0e9449e05
treea5aa9d7e51ef4fd0e353223bd691f7e85018a032
parent08f1e1f0a47b4b0e87b07b9794698747b279c711
Support domains over composite types.

This is the last major omission in our domains feature: you can now
make a domain over anything that's not a pseudotype.

The major complication from an implementation standpoint is that places
that might be creating tuples of a domain type now need to be prepared
to apply domain_check().  It seems better that unprepared code fail
with an error like "<type> is not composite" than that it silently fail
to apply domain constraints.  Therefore, relevant infrastructure like
get_func_result_type() and lookup_rowtype_tupdesc() has been adjusted
to treat domain-over-composite as a distinct case that unprepared code
won't recognize, rather than just transparently treating it the same
as plain composite.  This isn't a 100% solution to the possibility of
overlooked domain checks, but it catches most places.

In passing, improve typcache.c's support for domains (it can now cache
the identity of a domain's base type), and rewrite the argument handling
logic in jsonfuncs.c's populate_record[set]_worker to reduce duplicative
per-call lookups.

I believe this is code-complete so far as the core and contrib code go.
The PLs need varying amounts of work, which will be tackled in followup
patches.

Discussion: https://postgr.es/m/4206.1499798337@sss.pgh.pa.us
37 files changed:
contrib/hstore/hstore_io.c
doc/src/sgml/datatype.sgml
doc/src/sgml/rowtypes.sgml
doc/src/sgml/xfunc.sgml
src/backend/catalog/pg_inherits.c
src/backend/catalog/pg_proc.c
src/backend/commands/tablecmds.c
src/backend/commands/typecmds.c
src/backend/executor/execExprInterp.c
src/backend/executor/execSRF.c
src/backend/executor/functions.c
src/backend/executor/nodeFunctionscan.c
src/backend/nodes/makefuncs.c
src/backend/optimizer/util/clauses.c
src/backend/parser/parse_coerce.c
src/backend/parser/parse_func.c
src/backend/parser/parse_relation.c
src/backend/parser/parse_target.c
src/backend/parser/parse_type.c
src/backend/utils/adt/domains.c
src/backend/utils/adt/jsonfuncs.c
src/backend/utils/adt/ruleutils.c
src/backend/utils/cache/lsyscache.c
src/backend/utils/cache/typcache.c
src/backend/utils/fmgr/funcapi.c
src/include/access/htup_details.h
src/include/access/tupdesc.h
src/include/funcapi.h
src/include/nodes/primnodes.h
src/include/parser/parse_type.h
src/include/utils/typcache.h
src/test/regress/expected/domain.out
src/test/regress/expected/json.out
src/test/regress/expected/jsonb.out
src/test/regress/sql/domain.sql
src/test/regress/sql/json.sql
src/test/regress/sql/jsonb.sql