]> granicus.if.org Git - python/commit
Issue #9036: Throughout the code base, Py_CHARMASK is used on 8-bit wide
authorStefan Krah <stefan@bytereef.org>
Mon, 19 Jul 2010 12:36:57 +0000 (12:36 +0000)
committerStefan Krah <stefan@bytereef.org>
Mon, 19 Jul 2010 12:36:57 +0000 (12:36 +0000)
commit36d2e67db9a53175accad32454af6316d6b12b82
tree841d1e8a172e7cbf56ee8a3e41d7d164bfcb0701
parent067425520e68073c991a8e750e008b23b2564c68
Issue #9036: Throughout the code base, Py_CHARMASK is used on 8-bit wide
signed/unsigned chars or on integers directly derived from those. In all
cases, it could be replaced by a simple cast to (unsigned char). Reasons
for the change:

  a) Make the comment more explicit.

  b) If char is unsigned, the cast is optimized away.

  c) If char is unsigned, gcc emits spurious "array subscript
     has type 'char'" warnings.
Include/Python.h