]> granicus.if.org Git - postgresql/commit
Don't record FDW user mappings as members of extensions.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 7 Aug 2018 20:32:50 +0000 (16:32 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 7 Aug 2018 20:33:12 +0000 (16:33 -0400)
commit33c5d3bf85d7ae01ee66bb3a4d77abde85c0f8bf
treef0d3e532dd720c6da2bf08bb709cc62eb44851e1
parent753051cc721e9123e817b929b257e53a9b97a502
Don't record FDW user mappings as members of extensions.

CreateUserMapping has a recordDependencyOnCurrentExtension call that's
been there since extensions were introduced (very possibly my fault).
However, there's no support anywhere else for user mappings as members
of extensions, nor are they listed as a possible member object type in
the documentation.  Nor does it really seem like a good idea for user
mappings to belong to extensions when roles don't.  Hence, remove the
bogus call.

(As we saw in bug #15310, the lack of any pg_dump support for this case
ensures that any such membership record would silently disappear during
pg_upgrade.  So there's probably no need for us to do anything else
about cleaning up after this mistake.)

Discussion: https://postgr.es/m/27952.1533667213@sss.pgh.pa.us
src/backend/commands/foreigncmds.c