]> granicus.if.org Git - postgresql/commit
Fix logical replication's ideas about which type OIDs are built-in.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 13 May 2019 21:23:00 +0000 (17:23 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 13 May 2019 21:23:00 +0000 (17:23 -0400)
commit32ebb35128c3d16b64039f6d6774afd96a3d91b9
tree2aab15f686300d11d139c2422d2d21bd63536984
parente34ee993fbc38c8538f9342c5961e5f61fd45180
Fix logical replication's ideas about which type OIDs are built-in.

Only hand-assigned type OIDs should be presumed to match across different
PG servers; those assigned during genbki.pl or during initdb are likely
to change due to addition or removal of unrelated objects.

This means that the cutoff should be FirstGenbkiObjectId (in HEAD)
or FirstBootstrapObjectId (before that), not FirstNormalObjectId.
Compare postgres_fdw's is_builtin() test.

It's likely that this error has no observable consequence in a
normally-functioning system, since ATM the only affected type OIDs are
system catalog rowtypes and information_schema types, which would not
typically be interesting for logical replication.  But you could
probably break it if you tried hard, so back-patch.

Discussion: https://postgr.es/m/15150.1557257111@sss.pgh.pa.us
src/backend/replication/logical/relation.c
src/backend/replication/pgoutput/pgoutput.c