]> granicus.if.org Git - postgresql/commit
Handle heap rewrites even better in logical decoding
authorPeter Eisentraut <peter_e@gmx.net>
Wed, 21 Mar 2018 13:13:24 +0000 (09:13 -0400)
committerPeter Eisentraut <peter_e@gmx.net>
Wed, 21 Mar 2018 13:15:04 +0000 (09:15 -0400)
commit325f2ec5557fd1c9156c910102522e04cb42d99c
treed41044a9ebc9beec2809fe61289467b107802c25
parentbe8a7a6866276b228b4ffaa3003e1dc2dd1d140a
Handle heap rewrites even better in logical decoding

Logical decoding should not publish anything about tables created as
part of a heap rewrite during DDL.  Those tables don't exist externally,
so consumers of logical decoding cannot do anything sensible with that
information.  In ab28feae2bd3d4629bd73ae3548e671c57d785f0, we worked
around this for built-in logical replication, but that was hack.

This is a more proper fix: We mark such transient heaps using the new
field pg_class.relwrite, linking to the original relation OID.  By
default, we ignore them in logical decoding before they get to the
output plugin.  Optionally, a plugin can register their interest in
getting such changes, if they handle DDL specially, in which case the
new field will help them get information about the actual table.

Reviewed-by: Craig Ringer <craig@2ndquadrant.com>
20 files changed:
contrib/test_decoding/expected/concurrent_ddl_dml.out
contrib/test_decoding/expected/ddl.out
contrib/test_decoding/specs/concurrent_ddl_dml.spec
contrib/test_decoding/sql/ddl.sql
contrib/test_decoding/test_decoding.c
doc/src/sgml/catalogs.sgml
doc/src/sgml/logicaldecoding.sgml
src/backend/bootstrap/bootparse.y
src/backend/catalog/heap.c
src/backend/catalog/toasting.c
src/backend/commands/cluster.c
src/backend/commands/tablecmds.c
src/backend/replication/logical/logical.c
src/backend/replication/logical/reorderbuffer.c
src/backend/replication/pgoutput/pgoutput.c
src/include/catalog/catversion.h
src/include/catalog/heap.h
src/include/catalog/pg_class.h
src/include/replication/output_plugin.h
src/include/replication/reorderbuffer.h