]> granicus.if.org Git - postgresql/commit
Avoid passing function pointers across process boundaries.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 15 Apr 2017 03:50:16 +0000 (23:50 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 15 Apr 2017 03:50:16 +0000 (23:50 -0400)
commit32470825d36d99a81347ee36c181d609c952c061
tree0fe8bfc11dbb20ae8dfe943632674cd3bc859b79
parent5a617ab3e691aec56725960e6d28c98c8af6ddaa
Avoid passing function pointers across process boundaries.

We'd already recognized that we can't pass function pointers across process
boundaries for functions in loadable modules, since a shared library could
get loaded at different addresses in different processes.  But actually the
practice doesn't work for functions in the core backend either, if we're
using EXEC_BACKEND.  This is the cause of recent failures on buildfarm
member culicidae.  Switch to passing a string function name in all cases.

Something like this needs to be back-patched into 9.6, but let's see
if the buildfarm likes it first.

Petr Jelinek, with a bunch of basically-cosmetic adjustments by me

Discussion: https://postgr.es/m/548f9c1d-eafa-e3fa-9da8-f0cc2f654e60@2ndquadrant.com
src/backend/access/transam/README.parallel
src/backend/access/transam/parallel.c
src/backend/executor/execParallel.c
src/backend/postmaster/bgworker.c
src/backend/utils/fmgr/dfmgr.c
src/backend/utils/fmgr/fmgr.c
src/include/access/parallel.h
src/include/executor/execParallel.h
src/include/fmgr.h