]> granicus.if.org Git - postgresql/commit
Prevent failure when RowExpr or XmlExpr is parse-analyzed twice.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 23 Dec 2012 19:07:24 +0000 (14:07 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 23 Dec 2012 19:07:24 +0000 (14:07 -0500)
commit31bc839724439440b2e94ea616b28ce5be94e19c
tree1bd0a7137b12f16840be1f361eb2678415ad297e
parenteb035068121532ed7db47081e71655746d31cd16
Prevent failure when RowExpr or XmlExpr is parse-analyzed twice.

transformExpr() is required to cope with already-transformed expression
trees, for various ugly-but-not-quite-worth-cleaning-up reasons.  However,
some of its newer subroutines hadn't gotten the memo.  This accounts for
bug #7763 from Norbert Buchmuller: transformRowExpr() was overwriting the
previously determined type of a RowExpr during CREATE TABLE LIKE INCLUDING
INDEXES.  Additional investigation showed that transformXmlExpr had the
same kind of problem, but all the other cases seem to be safe.

Andres Freund and Tom Lane
src/backend/parser/gram.y
src/backend/parser/parse_expr.c
src/include/nodes/primnodes.h