]> granicus.if.org Git - postgresql/commit
Consistently test for in-use shared memory.
authorNoah Misch <noah@leadboat.com>
Thu, 4 Apr 2019 00:03:46 +0000 (17:03 -0700)
committerNoah Misch <noah@leadboat.com>
Thu, 4 Apr 2019 00:03:46 +0000 (17:03 -0700)
commit2f932f71d9f2963bbd201129d7b971c8f5f077fd
treea9647622166d61e3b7668eca618f37c47d864f5f
parentaf052daec5aa282eab2d22fa3b24d6109a30c2f3
Consistently test for in-use shared memory.

postmaster startup scrutinizes any shared memory segment recorded in
postmaster.pid, exiting if that segment matches the current data
directory and has an attached process.  When the postmaster.pid file was
missing, a starting postmaster used weaker checks.  Change to use the
same checks in both scenarios.  This increases the chance of a startup
failure, in lieu of data corruption, if the DBA does "kill -9 `head -n1
postmaster.pid` && rm postmaster.pid && pg_ctl -w start".  A postmaster
will no longer recycle segments pertaining to other data directories.
That's good for production, but it's bad for integration tests that
crash a postmaster and immediately delete its data directory.  Such a
test now leaks a segment indefinitely.  No "make check-world" test does
that.  win32_shmem.c already avoided all these problems.  In 9.6 and
later, enhance PostgresNode to facilitate testing.  Back-patch to 9.4
(all supported versions).

Reviewed by Daniel Gustafsson and Kyotaro HORIGUCHI.

Discussion: https://postgr.es/m/20130911033341.GD225735@tornado.leadboat.com
src/Makefile.global.in
src/backend/port/sysv_shmem.c
src/backend/port/win32_shmem.c
src/backend/postmaster/postmaster.c
src/backend/storage/ipc/ipci.c
src/backend/utils/init/postinit.c
src/include/storage/ipc.h
src/include/storage/pg_shmem.h
src/test/perl/PostgresNode.pm
src/test/recovery/t/017_shm.pl [new file with mode: 0644]
src/tools/msvc/vcregress.pl