]> granicus.if.org Git - postgresql/commit
Make dblink try harder to form useful error messages
authorJoe Conway <mail@joeconway.com>
Thu, 22 Dec 2016 17:48:05 +0000 (09:48 -0800)
committerJoe Conway <mail@joeconway.com>
Thu, 22 Dec 2016 17:48:55 +0000 (09:48 -0800)
commit2f802d95b4904dbed3dfdca1b3a607cd085d2e20
tree65e083bdc0a5e74b06549fe07a37a89df68f7bae
parent3ee80672847c4100d5f9efdb9ea19cb96506d089
Make dblink try harder to form useful error messages

When libpq encounters a connection-level error, e.g. runs out of memory
while forming a result, there will be no error associated with PGresult,
but a message will be placed into PGconn's error buffer. postgres_fdw
takes care to use the PGconn error message when PGresult does not have
one, but dblink has been negligent in that regard. Modify dblink to mirror
what postgres_fdw has been doing.

Back-patch to all supported branches.

Author: Joe Conway
Reviewed-By: Tom Lane
Discussion: https://postgr.es/m/02fa2d90-2efd-00bc-fefc-c23c00eb671e%40joeconway.com
contrib/dblink/dblink.c