]> granicus.if.org Git - postgresql/commit
Improve performance of ExecEvalWholeRowVar.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 26 Mar 2017 23:14:47 +0000 (19:14 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 26 Mar 2017 23:14:57 +0000 (19:14 -0400)
commit2f0903ea196503fc8af373a9de46b1e01a23508c
tree9eceb4a64d9f6585508fcb2a2c003110cf040cc2
parent895f93701fd78b6faab6b437685357298a91dfe3
Improve performance of ExecEvalWholeRowVar.

In commit b8d7f053c, we needed to fix ExecEvalWholeRowVar to not change
the state of the slot it's copying.  The initial quick hack at that
required two rounds of tuple construction, which is not very nice.
To fix, add another primitive to tuptoaster.c that does precisely what
we need.  (I initially tried to do this by refactoring one of the
existing functions into two pieces; but it looked like that might hurt
performance for the existing case, and the amount of code that could
be shared is not very large, so I gave up on that.)

Discussion: https://postgr.es/m/26088.1490315792@sss.pgh.pa.us
src/backend/access/heap/tuptoaster.c
src/backend/executor/execExprInterp.c
src/include/access/tuptoaster.h