]> granicus.if.org Git - postgresql/commit
projects / postgresql / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 6bb6958) | patch
Fix minor bugs in commit 30bf4689a96cd283af33edcdd6b7210df3f20cd8 et al.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 30 Nov 2014 17:20:47 +0000 (12:20 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 30 Nov 2014 17:20:47 +0000 (12:20 -0500)
commit2e2c8455fa9f9bae80a1e1edd780b78362b82404
treef39bcc173108c39688d8521615b49c48e0ce7a30tree | snapshot
parent6bb6958fa2614a5f18e9ac992f8f9956db59e9d1commit | diff
Fix minor bugs in commit 30bf4689a96cd283af33edcdd6b7210df3f20cd8 et al.

Coverity complained that the "else" added to fillPGconn() was unreachable,
which it was.  Remove the dead code.  In passing, rearrange the tests so as
not to bother trying to fetch values for options that can't be assigned.

Pre-9.3 did not have that issue, but it did have a "return" that should be
"goto oom_error" to ensure that a suitable error message gets filled in.
src/interfaces/libpq/fe-connect.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.