]> granicus.if.org Git - cgit/commit
gcc8.1: fix strncpy bounds warnings
authorAndy Green <andy@warmcat.com>
Tue, 26 Jun 2018 10:29:56 +0000 (18:29 +0800)
committerAndy Green <andy@warmcat.com>
Thu, 28 Jun 2018 23:53:20 +0000 (07:53 +0800)
commit2d789a817bd580670107125cb312e33a24bf8045
tree500d7db1ef57951d5b550fa73dff222735e04e44
parent9fc611c89f6662175dfeb007023754d038c79451
gcc8.1: fix strncpy bounds warnings

These warnings are coming on default Fedora 28 build and probably others using gcc 8.1

../shared.c: In function ‘expand_macro’:
../shared.c:483:3: warning: ‘strncpy’ specified bound depends on the length of the source argument [-Wstringop-overflow=]
   strncpy(name, value, len);
   ^~~~~~~~~~~~~~~~~~~~~~~~~
../shared.c:480:9: note: length computed here
   len = strlen(value);
         ^~~~~~~~~~~~~

strncpy with a computed length via strlen is usually
not the right thing.

Signed-off-by: Andy Green <andy@warmcat.com>
shared.c