]> granicus.if.org Git - postgresql/commit
Add a --socketdir option to pg_upgrade.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 1 Dec 2018 20:45:11 +0000 (15:45 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 1 Dec 2018 20:45:11 +0000 (15:45 -0500)
commit2d34ad84303181111c6f0747186857ff50106267
tree035be13102bd111bf96f5d1e4feb4f1251e48cea
parent7d4524aed3a4720086b2914ec22f1bbbc857ac44
Add a --socketdir option to pg_upgrade.

This allows control of the directory in which the postmaster sockets
are created for the temporary postmasters started by pg_upgrade.
The default location remains the current working directory, which is
typically fine, but if it is deeply nested then its pathname might
be too long to be a socket name.

In passing, clean up some messiness in pg_upgrade's option handling,
particularly the confusing and undocumented way that configuration-only
datadirs were handled.  And fix check_required_directory's substantially
under-baked cleanup of directory pathnames.

Daniel Gustafsson, reviewed by Hironobu Suzuki, some code cleanup by me

Discussion: https://postgr.es/m/E72DD5C3-2268-48A5-A907-ED4B34BEC223@yesql.se
doc/src/sgml/ref/pgupgrade.sgml
src/bin/pg_upgrade/option.c
src/bin/pg_upgrade/pg_upgrade.h