]> granicus.if.org Git - llvm/commit
add 'a' to chmod in llvm-lipo executability tests
authorBob Haarman <llvm@inglorion.net>
Fri, 26 Jul 2019 18:44:06 +0000 (18:44 +0000)
committerBob Haarman <llvm@inglorion.net>
Fri, 26 Jul 2019 18:44:06 +0000 (18:44 +0000)
commit2bf57b9730b3bc95165ff7061a5618c8afd48adb
tree6b331438e9b418454f1f612a5c79ddbc37fbd428
parentbdbb3c3d48718064e2aac85b06a4546b6ab86045
add 'a' to chmod in llvm-lipo executability tests

Summary:
When specifying symbolic permissions with + or -, if none of
a/u/g/o are specified, bits set in the umask are not affected.
This caused the llvm-lipo executability tests to fail on some
systems, e.g. having an umask of 027 would cause chmod -x to not
clear the executable bit for others. This change instead
uses chmod a-x, which clears all the executable bits regardless
of umask.

Reviewers: smeenai, hans, anushabasana

Reviewed By: smeenai

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D65342

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@367142 91177308-0d34-0410-b5e6-96231b3b80d8
test/tools/llvm-lipo/create-executable.test
test/tools/llvm-lipo/thin-executable-universal-binary.test