]> granicus.if.org Git - postgresql/commit
Repair unsafe/unportable snprintf usage in pg_restore.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 10 Feb 2019 00:45:38 +0000 (19:45 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 10 Feb 2019 00:45:38 +0000 (19:45 -0500)
commit2b6009e2a2794df286939e5ce1196a23cca07d68
tree096f0d73b05489e7a9f3d9d53b39ffbdceeec3c1
parent6257f525aff4e711d7eb5405626e7eeac37e2ff5
Repair unsafe/unportable snprintf usage in pg_restore.

warn_or_exit_horribly() was blithely passing a potentially-NULL
string pointer to a %s format specifier.  That works (at least
to the extent of not crashing) on some platforms, but not all,
and since we switched to our own snprintf.c it doesn't work
for us anywhere.

Of the three string fields being handled this way here, I think
that only "owner" is supposed to be nullable ... but considering
that this is error-reporting code, it has very little business
assuming anything, so put in defenses for all three.

Per a crash observed on buildfarm member crake and then
reproduced here.  Because of the portability aspect,
back-patch to all supported versions.
src/bin/pg_dump/pg_backup_archiver.c