]> granicus.if.org Git - postgresql/commit
Revert "Do execGrouping.c via expression eval machinery."
authorAndres Freund <andres@anarazel.de>
Fri, 16 Feb 2018 06:39:18 +0000 (22:39 -0800)
committerAndres Freund <andres@anarazel.de>
Fri, 16 Feb 2018 06:39:18 +0000 (22:39 -0800)
commit2a41507dab0f293ff241fe8ae326065998668af8
tree30fe1118750ea9c2805bd38a7485390f4d381715
parent773aec7aa98abd38d6d9435913bb8e14e392c274
Revert "Do execGrouping.c via expression eval machinery."

This reverts commit 773aec7aa98abd38d6d9435913bb8e14e392c274.

There's an unresolved issue in the reverted commit: It only creates
one comparator function, but in for the nodeSubplan.c case we need
more (c.f. FindTupleHashEntry vs LookupTupleHashEntry calls in
nodeSubplan.c).

This isn't too difficult to fix, but it's not entirely trivial
either. The fact that the issue only causes breakage on 32bit systems
shows that the current test coverage isn't that great.  To avoid
turning half the buildfarm red till those two issues are addressed,
revert.
15 files changed:
src/backend/executor/execExpr.c
src/backend/executor/execExprInterp.c
src/backend/executor/execGrouping.c
src/backend/executor/nodeAgg.c
src/backend/executor/nodeGroup.c
src/backend/executor/nodeRecursiveunion.c
src/backend/executor/nodeSetOp.c
src/backend/executor/nodeSubplan.c
src/backend/executor/nodeUnique.c
src/backend/executor/nodeWindowAgg.c
src/backend/utils/adt/orderedsetaggs.c
src/include/executor/execExpr.h
src/include/executor/executor.h
src/include/executor/nodeAgg.h
src/include/nodes/execnodes.h