]> granicus.if.org Git - postgresql/commit
Fix race condition in pg_ctl reading postmaster.pid.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Sat, 13 Oct 2012 09:48:14 +0000 (12:48 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 15 Oct 2012 07:54:40 +0000 (10:54 +0300)
commit288367427472f3d300c51ff9941eb486cfc01c6a
treeeed9d4145738647a1bbf41d6d9c8124f345ba001
parenteb5e0d8488451bcfcf81e26fd82dd9687c99b941
Fix race condition in pg_ctl reading postmaster.pid.

If postmaster changed postmaster.pid while pg_ctl was reading it, pg_ctl
could overrun the buffer it allocated for the file. Fix by reading the
whole file to memory with one read() call.

initdb contains an identical copy of the readfile() function, but the files
that initdb reads are static, not modified concurrently. Nevertheless, add
a simple bounds-check there, if only to silence static analysis tools.

Per report from Dave Vitek. Backpatch to all supported branches.
src/bin/initdb/initdb.c
src/bin/pg_ctl/pg_ctl.c