]> granicus.if.org Git - postgresql/commit
Fix pg_dumpall to work for databases flagged as read-only.
authorKevin Grittner <kgrittn@postgresql.org>
Sat, 30 Nov 2013 17:33:54 +0000 (11:33 -0600)
committerKevin Grittner <kgrittn@postgresql.org>
Sat, 30 Nov 2013 17:33:54 +0000 (11:33 -0600)
commit27b33245a5f505794a0e8dd4cdb9342f8cf2cc0a
treed5cc51032561749c391ed1ca23b4cd317e38bbf2
parent8f8c666144226860d8d766054f6c8f3d78862e8b
Fix pg_dumpall to work for databases flagged as read-only.

pg_dumpall's charter is to be able to recreate a database cluster's
contents in a virgin installation, but it was failing to honor that
contract if the cluster had any ALTER DATABASE SET
default_transaction_read_only settings.  By including a SET command
for the connection for each connection opened by pg_dumpall output,
errors are avoided and the source cluster is successfully
recreated.

There was discussion of whether to also set this for the connection
applying pg_dump output, but it was felt that it was both less
appropriate in that context, and far easier to work around.

Backpatch to all supported branches.
src/bin/pg_dump/pg_dumpall.c