]> granicus.if.org Git - postgresql/commit
Fix line end mishandling in pg_upgrade on Windows.
authorAndrew Dunstan <andrew@dunslane.net>
Wed, 5 Sep 2012 21:49:09 +0000 (17:49 -0400)
committerAndrew Dunstan <andrew@dunslane.net>
Wed, 5 Sep 2012 21:49:09 +0000 (17:49 -0400)
commit26f4fc01849b23d0541722d7cfdbd08739f81e1c
treef3e7db0d6ccd1e76a8bb9618ea1817a238e2c780
parent5ee0f03727eb7452ad8ecbca660d500ab78ac015
Fix line end mishandling in pg_upgrade on Windows.

pg_upgrade opened the output from pg_dumpall in text mode and
wrote the split files in text mode. This caused unwanted eating
of intended carriage returns on input and production of spurious
carriage returns on output. To avoid this, open all these files
in binary mode. On non-Windows platforms, this change has no
effect.

Backpatch to 9.0. On 9.0 and 9.1, we also switch from redirecting
pg_dumpall's output to using pg_dumpall's -f switch, for the same
reason.
contrib/pg_upgrade/dump.c